CLOS-2816: Cap disk image size to filesystem file size limit#63
Merged
prilr merged 2 commits intoMay 17, 2026
Merged
Conversation
On systems with large partitions (e.g. /home on a SAN with ~19 TB free), the target_userspace_creator actor tried to create a sparse disk image whose apparent size exceeded the 16 TiB maximum file size of ext4 (4K blocks), causing dd to fail with exit code 1. Add _get_max_diskimage_size_mibs() which uses os.pathconf's PC_FILESIZEBITS to determine the actual file size limit of the disk images filesystem, then cap each disk image size to that limit in _prepare_required_mounts(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
azheregelya
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On systems with large partitions (e.g. /home on a SAN with ~19 TB free), the target_userspace_creator actor tried to create a sparse disk image whose apparent size exceeded the 16 TiB maximum file size of ext4 (4K blocks), causing dd to fail.
Add
_get_max_diskimage_size_mibs()which uses os.pathconf'sPC_FILESIZEBITSto determine the actual file size limit of the disk images filesystem, then cap each disk image size to that limit in_prepare_required_mounts().