CLOS-3465: Inhibit upgrade when _netdev found in fstab#62
Merged
prilr merged 2 commits intoMay 12, 2026
Merged
Conversation
During in-place upgrade, leapp disconnects the system from the network before the first reboot. Any fstab entry with the _netdev option relies on network availability and cannot be mounted at that stage, causing the upgrade to fail. Add check_netdev_mounts() to the CheckMountOptions actor to detect such entries and report an inhibitor. The check is bypassed when LEAPP_DEVEL_INITRAM_NETWORK is set (network available in initramfs). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When an fstab entry pairs _netdev with nofail, systemd will not fail the
boot if the mount cannot be brought up - the standard idiom for non-
critical network mounts. Inhibiting these would be a false positive: the
upgrade proceeds past the first reboot whether the mount succeeds or not.
Validated on a CL7 test VM (template USERLAND-AUTO-all_in_one-CL7.stable.cpanel-11.110):
- _netdev,defaults -> inhibitor fires (3 total inhibitors)
- _netdev,nofail -> inhibitor does not fire (2 total inhibitors,
grep -c 'netdev' on report = 0)
Also reword summary/remediation to mention the nofail escape hatch.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
azheregelya
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During in-place upgrade, leapp disconnects the system from the network before the first reboot.
Any fstab entry with the _netdev option relies on network availability and cannot be mounted at that stage, causing the upgrade to fail.
Add check_netdev_mounts() to the CheckMountOptions actor to detect such entries and report an inhibitor.
The check is bypassed when
nofailis set for the entry LEAPP_DEVEL_INITRAM_NETWORK is set (network available in initramfs).