add resource_id and is_external properties - #1238
Open
EarthmanT wants to merge 1 commit into
Open
Conversation
EarthmanT
force-pushed
the
RD-3386-resource-id-ctx
branch
10 times, most recently
from
February 1, 2023 14:07
122f569 to
d044268
Compare
EarthmanT
force-pushed
the
RD-3386-resource-id-ctx
branch
5 times, most recently
from
February 1, 2023 18:14
14c36b7 to
595599c
Compare
add resource_id and is_external properties ok
EarthmanT
force-pushed
the
RD-3386-resource-id-ctx
branch
from
February 1, 2023 18:34
595599c to
47a9cf7
Compare
mateumann
reviewed
Feb 2, 2023
Comment on lines
+407
to
+410
| try: | ||
| return self._node.properties | ||
| except AttributeError: | ||
| return self._node.get('properties') |
Contributor
There was a problem hiding this comment.
Is it really necessary (other than in test)?
mateumann
reviewed
Feb 2, 2023
mateumann
left a comment
mateumann
left a comment
Contributor
There was a problem hiding this comment.
Are you sure you have to include that wagon file?
tehasdf
requested changes
Feb 2, 2023
tehasdf
left a comment
tehasdf
left a comment
Contributor
There was a problem hiding this comment.
remember to remove the dev-reqs.txt & .wgn (accidentally committed?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.