This repository was archived by the owner on Feb 14, 2023. It is now read-only.
Fix #117 - Add longer health check timeout on register-buddy container#120
Open
nicko170 wants to merge 1 commit into
Open
Fix #117 - Add longer health check timeout on register-buddy container#120nicko170 wants to merge 1 commit into
nicko170 wants to merge 1 commit into
Conversation
Collaborator
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/181054922 The labels on this github issue will be updated when the story is started. |
|
This pull request was marked as |
Author
|
Bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Australia is a loooong way away from hub.docker.com, which causes the register-buddy sidecar to constantly crash as seen in #117. Every request to /healthz calls the external API service before responding, and 1 second timeout is simply not enough time.
Adding a 3 second check timeout here fixes the issue, vs the default liveness check timeout of 1 second.