Skip to content

Revert "Pin http-cookie < 1.1 for delete-vms task on Ruby 3.4" - #188

Merged
selzoc merged 1 commit into
windows-2019from
revert-164-fix-create-azure
Jul 31, 2026
Merged

Revert "Pin http-cookie < 1.1 for delete-vms task on Ruby 3.4"#188
selzoc merged 1 commit into
windows-2019from
revert-164-fix-create-azure

Conversation

@selzoc

@selzoc selzoc commented Jul 31, 2026

Copy link
Copy Markdown
Member

Reverts #164

Looks like this was fixed in 1.1.5 sparklemotion/http-cookie#62 (comment)

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 03612561-cdc1-41aa-a21a-fd4adebf6664

📥 Commits

Reviewing files that changed from the base of the PR and between a53620f and 46485ac.

📒 Files selected for processing (1)
  • ci/tasks/delete-vms/Gemfile
💤 Files with no reviewable changes (1)
  • ci/tasks/delete-vms/Gemfile

Walkthrough

The VM deletion task Gemfile removes the http-cookie version constraint and its explanatory comment.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the reverted http-cookie version pin for the delete-vms task.
Description check ✅ Passed The description explains that the pull request reverts the pin because the issue was fixed in http-cookie 1.1.5.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-164-fix-create-azure

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@selzoc
selzoc merged commit 1302203 into windows-2019 Jul 31, 2026
15 checks passed
@selzoc
selzoc deleted the revert-164-fix-create-azure branch July 31, 2026 20:23
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants