Skip to content

Improve Wrangler Preview warning output - #15433

Draft
yomna-shousha wants to merge 2 commits into
cloudflare:mainfrom
yomna-shousha:yomna/previews-output-warnings
Draft

Improve Wrangler Preview warning output#15433
yomna-shousha wants to merge 2 commits into
cloudflare:mainfrom
yomna-shousha:yomna/previews-output-warnings

Conversation

@yomna-shousha

@yomna-shousha yomna-shousha commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Move missing Preview binding warnings before the final URL summary and mark the Preview status as with warnings.
  • Make the missing-bindings warning say the deployment succeeded, the URL is live when active, and missing runtime bindings can change behavior.
  • Improve the no-active-URLs guidance with the correct config fields and section-specific docs links.
  • Warn when wrangler preview runs with a Wrangler version below 4.127.1, and point users at their project-local Wrangler install.

Validation:

  • pnpm exec oxfmt --check packages/deploy-helpers/src/preview/preview.ts packages/wrangler/src/preview/preview.ts packages/wrangler/src/preview/version-warning.ts packages/wrangler/src/tests/preview.test.ts packages/wrangler/src/tests/preview.secret.test.ts packages/wrangler/src/tests/preview-version-warning.test.ts
  • git diff --check -- packages/deploy-helpers/src/preview/preview.ts packages/wrangler/src/preview/preview.ts packages/wrangler/src/preview/version-warning.ts packages/wrangler/src/tests/preview.test.ts packages/wrangler/src/tests/preview.secret.test.ts packages/wrangler/src/tests/preview-version-warning.test.ts
  • pnpm --filter wrangler test run src/tests/preview-version-warning.test.ts

Known limitation:

  • pnpm --filter wrangler test run src/tests/preview.test.ts -t "should warn about top-level bindings missing from preview settings|should note when URL arrays are empty" is blocked in this checkout by existing workspace/test setup failures: writeOutput is not a function and clearOutputFilePath is not a function.

Note:

  • The no-active-URLs docs links point to section anchors in the updated Workers Previews custom domains docs.
  • Users already running old project-local Wrangler will only see the version warning if this change is included in that release line or they invoke a newer Wrangler once.

@changeset-bot

changeset-bot Bot commented Aug 30, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e593792

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Aug 30, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15433

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15433

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15433

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15433

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15433

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15433

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15433

miniflare

npm i https://pkg.pr.new/miniflare@15433

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15433

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15433

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15433

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15433

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15433

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15433

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15433

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15433

wrangler

npm i https://pkg.pr.new/wrangler@15433

commit: e593792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants