boring-sys: Bump BoringSSL to e2a57cfb4#509
Merged
Merged
Conversation
00e5c99 to
683dd94
Compare
lukevalenta
approved these changes
May 27, 2026
lukevalenta
reviewed
May 27, 2026
Contributor
lukevalenta
left a comment
There was a problem hiding this comment.
Upstream added a new field to these test structs: google/boringssl@bf6bb32
8305960 to
aef32ec
Compare
aef32ec to
683dd94
Compare
Collaborator
Author
Hmm, I tried applying your suggestions, and applying the patch failed: Doesn't the patch already account for this? |
683dd94 to
90e3b51
Compare
This version includes integration of ML-DSA into TLS. Update the boring-pq, rpk, and underscore-wildcards patches accordingly.
90e3b51 to
b4fe1ae
Compare
lukevalenta
reviewed
May 28, 2026
Contributor
Whoops yeah I guess that suggested edit didn't account for line number changes in the patch, but looks like you got that part sorted! Left a comment above with how I think we can fix the remaining failing tests. |
Add a CI job that applies all patches to BoringSSL then runs the BoringSSL unit tests. Co-authored-by: Luke Valenta <lvalenta@cloudflare.com>
f3b5112 to
0b12575
Compare
bwesterb
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version includes integration of ML-DSA into TLS. Update the boring-pq and rpk patches accordingly.
While at it, run add a job to CI that runs BoringSSL's unit tests against the patched version.