Fix RSAPBSSA modulus length#58
Open
thibmeu wants to merge 2 commits into
Open
Conversation
Lekensteyn
reviewed
Jun 17, 2026
|
|
||
| // 1. p = SafePrime(bits / 2) | ||
| // 2. q = SafePrime(bits / 2) | ||
| // 3. while p == q, go to step 2. |
There was a problem hiding this comment.
These comments are now out-of-date with the implementation.
Haven't looked into detail yet, but:
I don't think this is the right place for a fix, generateSafePrime should be changed if we want to enforce a lower bound.
And if the concern is that we get more bits than requested, then that's also a problem in generateSafePrime I think?
Member
Author
There was a problem hiding this comment.
I think the comments are still matching the spec: the loop still performs KeyGen steps 1-3. The extra check only retries when the final modulus is one bit short, which is needed to enforce the requested modulusLength.
Also, enforcing modulus length at the start seems ok as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56