Fix reasoning chunks in approval continuations#1481
Open
whoiskatrin wants to merge 3 commits intomainfrom
Open
Fix reasoning chunks in approval continuations#1481whoiskatrin wants to merge 3 commits intomainfrom
whoiskatrin wants to merge 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 6c20048 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1480.
When a
needsApprovaltool is approved withautoContinueAfterToolResultenabled, the auto-continuation stream can resume from an assistant message that already contains a completed reasoning part.Two related issues were happening in that path:
The continuation's
reasoning-startcould be suppressed before reaching the client, so AI SDK v6 sawreasoning-delta/reasoning-endwithout a precedingreasoning-startand threw:After forwarding
reasoning-startto fix the stream protocol, completed prior reasoning could still cause the server-side continuation builder to merge new reasoning into the existing reasoning block. That made the live stream look correct, but the final persisted/rehydrated assistant message did not keep the continuation reasoning as its own persisted reasoning part, so the reasoning block disappeared after the response finished.This PR keeps the client stream and persisted message in sync:
reasoning-start→reasoning-delta→reasoning-endsequenceChanges
reasoning-startduring approval continuations so AI SDK v6 receives a valid reasoning lifecycle.reasoning-startapplication when resuming an existingstate: "streaming"reasoning part.done.@cloudflare/ai-chat.Testing
npm run checkcompletes successfully. It still prints existingsherifwarnings for package-less workspace directories, unrelated to this change.