Skip to content

Remove feature flag showMessage. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cloudbees-platform wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove feature flag showMessage. #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,15 @@ import (
)

type Flags struct {
ShowMessage server.RoxFlag
Message server.RoxString
FontColor server.RoxString
FontSize server.RoxInt
Message server.RoxString
FontColor server.RoxString
FontSize server.RoxInt
}

var flags = &Flags{
ShowMessage: server.NewRoxFlag(false),
Message: server.NewRoxString("This is the default message; try changing some flag values!", []string{}),
FontColor: server.NewRoxString("Black", []string{"Red", "Green", "Blue", "Black"}),
FontSize: server.NewRoxInt(12, []int{12, 16, 24}),
Message: server.NewRoxString("This is the default message; try changing some flag values!", []string{}),
FontColor: server.NewRoxString("Black", []string{"Red", "Green", "Blue", "Black"}),
FontSize: server.NewRoxInt(12, []int{12, 16, 24}),
}

func initFlags() {
Expand Down Expand Up @@ -48,11 +46,6 @@ func homePage(c *gin.Context) {
}

func demo(c *gin.Context) {
msg := ""
if flags.ShowMessage.IsEnabled(nil) {
msg = flags.Message.GetValue(nil)
} else {
msg = "Flag message hidden. Enable the flag in the Cloudbees platform to display it."
}
msg := flags.Message.GetValue(nil)
c.IndentedJSON(http.StatusOK, gin.H{"message": msg, "fontColor": flags.FontColor.GetValue(nil), "fontSize": flags.FontSize.GetValue(nil)})
}