feat(server-nestjs): add environment API v2#2310
Draft
KepoParis wants to merge 1 commit into
Draft
Conversation
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
KepoParis
force-pushed
the
feat/environment-api-v2
branch
from
ccd954a to
6f0ddcc
Compare
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
KepoParis
force-pushed
the
feat/environment-api-v2
branch
from
6f0ddcc to
6c9fbd3
Compare
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
KepoParis
force-pushed
the
feat/environment-api-v2
branch
from
6c9fbd3 to
a9736fd
Compare
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Issues numéro:
Quel est le comportement actuel ?
La gestion des environnements est servie uniquement par le serveur legacy (
apps/server) via les routes/api/v1/environments(ts-rest/Fastify), avec des hooks bloquants : la réponse HTTP attend la reconciliation des plugins et renvoie une 500 en cas d'échec.Quel est le nouveau comportement ?
L'API environnements est migrée vers
apps/server-nestjssous de nouvelles routesapi/v2/projects/:projectId/environments, sur le modèle du moduledeployment:environment(controller/service/datastore + specs) sécurisé par leProjectGuardexistant (ListEnvironments/ManageEnvironments, projet non verrouillé et non archivé pour les mutations) ;AppEventsService(project.upsert) au lieu des hooks bloquants ;environmentIdd'un autre projet renvoie 404 ;environmentContractV2dans@cpn-console/shared(apiPrefixV2 = '/api/v2', schémasCreateEnvironmentSchema/UpdateEnvironmentSchema) ;/api/v2sont routées vers server-nestjs.Les routes legacy
/api/v1/environmentsrestent servies parapps/serverle temps de la migration (aucun code legacy supprimé) ; le client continue d'utiliser le contrat v1 pour l'instant.Cette PR introduit-elle un breaking change ?
Non. Les routes v1 sont inchangées, l'API v2 est additive.
Autres informations
La bascule du client vers
EnvironmentsV2puis le retrait de la route v1 legacy se feront dans des PRs ultérieures.