fix(server-nestjs/nexus): fall back to public Nexus URL when internal URL is unset#2302
Draft
KepoParis wants to merge 1 commit into
Draft
fix(server-nestjs/nexus): fall back to public Nexus URL when internal URL is unset#2302KepoParis wants to merge 1 commit into
KepoParis wants to merge 1 commit into
Conversation
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
KepoParis
force-pushed
the
fix/nexus-internal-url-error
branch
from
4b413ee to
e0e93ad
Compare
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
shikanime
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Issues numéro:
Quel est le comportement actuel ?
Le
NexusHttpClientServiceexige que la variable d'environnementNEXUS_INTERNAL_URLsoit définie. Si elle est absente, uneNexusError(NotConfigured) est levée immédiatement, même lorsqu'une URL publique Nexus (NEXUS_URL) est disponible et pourrait être utilisée.Quel est le nouveau comportement ?
Le getter
baseUrlutilise désormaisconfig.getInternalOrPublicNexusUrl(): il privilégie l'URL interne (NEXUS_INTERNAL_URL) et se rabat sur l'URL publique (NEXUS_URL) si l'URL interne n'est pas définie. L'erreurNotConfiguredn'est levée que si aucune des deux URLs n'est configurée, avec un message mis à jour (NEXUS_INTERNAL_URL or NEXUS_URL is required).Cette PR introduit-elle un breaking change ?
Non. Les déploiements existants avec
NEXUS_INTERNAL_URLdéfinie conservent le même comportement. Le changement rend simplement la configuration plus permissive pour les environnements où seuleNEXUS_URLest définie.Autres informations
Aucune.