Skip to content

refactor(server-nestjs): offload project route to new implementation#2281

Open
shikanime wants to merge 1 commit into
mainfrom
shikanime/push-zwklmpnmuszy
Open

refactor(server-nestjs): offload project route to new implementation#2281
shikanime wants to merge 1 commit into
mainfrom
shikanime/push-zwklmpnmuszy

Conversation

@shikanime

@shikanime shikanime commented Jul 2, 2026

Copy link
Copy Markdown
Member

Change-Id: Ia8e16b188470eb80764717c3cd8068106a6a6964
Signed-off-by: William Phetsinorath william.phetsinorath@shikanime.studio
Signed-off-by: Shikanime Deva william.phetsinorath@shikanime.studio## Issues liées

Issues numéro: #2153

Quel est le comportement actuel ?

Quel est le nouveau comportement ?

Cette PR introduit-elle un breaking change ?

Autres informations

@shikanime shikanime added this to the 9.20.0 milestone Jul 2, 2026
@shikanime shikanime requested a review from KepoParis July 2, 2026 08:03
@shikanime shikanime self-assigned this Jul 2, 2026
@shikanime shikanime added technical debt Résoud de la dette technique tech Technical issue labels Jul 2, 2026
@shikanime shikanime force-pushed the shikanime/push-zwklmpnmuszy branch from d5cd63f to 4b6d987 Compare July 2, 2026 08:06
@github-actions github-actions Bot added the built label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-zwklmpnmuszy branch 3 times, most recently from 7af10eb to 8cd072f Compare July 2, 2026 13:05
@shikanime shikanime added the preview Deploy preview app with Argo-cd label Jul 2, 2026
@shikanime shikanime changed the title refactor(server-nestjs): migrate project route refactor(server-nestjs): offload project route to new implementation Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

A preview of the application is available at : https://console-pr-2281.dso.cpin-hp.numerique-interieur.fr

Please be patient, deployment may take a few minutes.

@shikanime shikanime force-pushed the shikanime/push-zwklmpnmuszy branch 2 times, most recently from 7c174d2 to ca48b5e Compare July 2, 2026 13:10
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

1 similar comment
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-zwklmpnmuszy branch 2 times, most recently from 267af55 to bc26f99 Compare July 2, 2026 13:15
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

1 similar comment
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-zwklmpnmuszy branch from bc26f99 to 2963f21 Compare July 2, 2026 13:41
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-zwklmpnmuszy branch from 2963f21 to 7787d10 Compare July 2, 2026 14:16
@shikanime shikanime enabled auto-merge July 2, 2026 14:19
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-zwklmpnmuszy branch from 7787d10 to 358aba1 Compare July 2, 2026 14:28
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-zwklmpnmuszy branch from 358aba1 to ead1f94 Compare July 2, 2026 14:35
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the shikanime/push-zwklmpnmuszy branch from c4abc68 to 057d515 Compare July 8, 2026 15:03
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

4 similar comments
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

github-code-quality[bot]
github-code-quality Bot found potential problems Jul 8, 2026
View reviewed changes
Comment thread apps/server-nestjs/src/modules/keycloak/keycloak-datastore.spec.ts Fixed
Comment thread apps/server-nestjs/src/modules/keycloak/keycloak-datastore.spec.ts Fixed
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

1 similar comment
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

github-code-quality[bot]
github-code-quality Bot found potential problems Jul 8, 2026
View reviewed changes
Comment thread apps/server-nestjs/src/modules/keycloak/keycloak-datastore.spec.ts Fixed
Comment thread apps/server-nestjs/src/modules/keycloak/keycloak-datastore.spec.ts Fixed
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

14 similar comments
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime
refactor(server-nestjs): offload project route to new implementation
5cddfd0 
Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio>
Change-Id: Ibaedb462036f3efbeb4853c5958ee5a06a6a6964
Signed-off-by: Shikanime Deva <contact@shikanime.studio>
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
@cloud-pi-native-sonarqube

cloud-pi-native-sonarqube Bot commented Jul 15, 2026

Copy link
Copy Markdown

Passed Quality Gate passed

Issues

Measures

Project ID: cloud-pi-native_console_AYsa46O31ebDtzs-pYyZ

View in SonarQube

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

StephaneTrebel
StephaneTrebel approved these changes Jul 15, 2026
View reviewed changes

@StephaneTrebel StephaneTrebel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, juste une remarque mais ce n'est pas bloquant 😉

Comment thread .../server-nestjs/documentation/Modularisation-de-console-server/MODULARISATION-CARTOGRAPHIE.md
| 17 | service-chain | Metier | 5.9 | V3 | S8 | ✅ MIGRE |
| 18 | repository | Metier | 5.8 | V3 | S7-S8 | |
| 19 | cluster | Metier | 5.7 | V3 | S7 | |
| 9 | service-monitor | Metier | 6.6 | V2 | S5 | 📅 Planifié (non trouvé dans la codebase actuelle) |

@StephaneTrebel StephaneTrebel Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: et apps/server/src/resources/service-monitor/router.ts, c'est quoi ? 😁

Comment thread apps/nginx-strangler/conf.d/routing.conf
}

location ~ ^/api/v1/projects/[^/]+/deployments(.*)$ {
location /api/v1/projects {

@StephaneTrebel StephaneTrebel Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Ah mais c'est la seule modification "technique", en fait ?

make the change easy (warning: this may be hard), then make the easy change

https://nitter.net/KentBeck/status/250733358307500032

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephaneTrebel StephaneTrebel StephaneTrebel approved these changes
@KepoParis KepoParis Awaiting requested review from KepoParis
+1 more reviewer
@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@shikanime shikanime

Labels

built preview Deploy preview app with Argo-cd tech Technical issue technical debt Résoud de la dette technique

Projects

None yet

Milestone

9.20.0

Development

Successfully merging this pull request may close these issues.

2 participants

@shikanime @StephaneTrebel