refactor(user-tokens): migrate from server by shikanime · Pull Request #2279 · cloud-pi-native/console

shikanime · 2026-06-30T09:42:04Z

Issues liées

Issues numéro: #1889

Quel est le comportement actuel ?

Quel est le nouveau comportement ?

Cette PR introduit-elle un breaking change ?

Autres informations

github-actions · 2026-07-01T13:39:37Z

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions · 2026-07-02T16:45:21Z

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions · 2026-07-03T14:12:13Z

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions · 2026-07-03T15:35:35Z

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions · 2026-07-07T10:53:01Z

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions · 2026-07-08T08:37:50Z

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions · 2026-07-08T09:17:26Z

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions · 2026-07-08T09:47:38Z

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions · 2026-07-08T10:02:20Z

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions · 2026-07-08T10:04:57Z

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions · 2026-07-13T09:25:06Z

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions · 2026-07-13T12:43:10Z

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions · 2026-07-13T13:39:07Z

🤖 Hey !

The security scan report for the current pull request is available here.

Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio> Change-Id: I5b6db65fcf411b3bfddc4a72430b8d4c6a6a6964

github-actions · 2026-07-15T12:22:18Z

🤖 Hey !

The security scan report for the current pull request is available here.

cloud-pi-native-sonarqube · 2026-07-15T12:22:28Z

Quality Gate passed

Issues

Measures

Project ID: cloud-pi-native_console_AYsa46O31ebDtzs-pYyZ

View in SonarQube

StephaneTrebel · 2026-07-15T12:09:11Z

issue: tant qu'on n'a pas statué sur le sujet, je préfère qu'on ne commite aucun "plan"

StephaneTrebel · 2026-07-15T12:09:55Z

 | Decision | Choix |
 |----------|-------|
-| Approche migration | Bottom-up (feuilles d'abord, puis remontee vers les modules couples) |
+| Approche migration | Bottom-up (feuilles d'abord, puis remonttee vers les modules couples) |


StephaneTrebel · 2026-07-15T12:12:24Z

+  @Get()
+  @RequireAdminPermission('ListAdminToken')
+  async list(@Query('withRevoked') withRevoked?: string) {
+    return this.service.list(withRevoked !== undefined && withRevoked !== 'false')


suggestion: ça ne serait pas mieux avec:

Suggested change

return this.service.list(withRevoked !== undefined && withRevoked !== 'false')

return this.service.list(withRevoked === 'true')

?
Parce que bon avec withRevoked = "chocapics", ça passe 😅

StephaneTrebel · 2026-07-15T12:14:21Z

+  constructor(@Inject(PrismaService) private readonly prisma: PrismaService) {}
+
+  @StartActiveSpan()
+  async list(withRevoked?: boolean) {


suggestion: Ouais donc effectivement y a zéro raison que withRevoked soit autre chose qu'un booléen.

Parse, don't validate

StephaneTrebel · 2026-07-15T12:18:00Z

+    this.logger.log(`adminToken.create started (tokenName=${data.name})`)
+
+    if (data.expirationDate && !isAtLeastTomorrow(new Date(data.expirationDate))) {
+      this.logger.warn(`adminToken.create rejected (tokenName=${data.name}, reason=expirationTooSoon)`)


issue: la date peut aussi être invalide (new Date("toto") === "Invalid Date"), et je ne vois rien qui l'indique clairement.
Niveau traçabilité, c'est pas top

StephaneTrebel · 2026-07-15T12:23:27Z

    try {
      const response = await fetch(url)
-      if (response.status < 500) return indicator.up({ httpStatus: response.status })
+      if (response.status < HttpStatus.INTERNAL_SERVER_ERROR) return indicator.up({ httpStatus: response.status })


praise: Ah ben je me demandais dans une autre MR si on avait des constantes pour ça. Je me disais bien qu'on avait ce qu'il faut 😁

StephaneTrebel · 2026-07-15T12:25:18Z

+
+  @Get()
+  async list(@AuthUser() user: UserContext) {
+    if (!user.userId || user.userType !== 'human') {


issue: s/'human'/HUMAN_KIND

StephaneTrebel · 2026-07-15T12:25:54Z

+  }
+
+  @Post()
+  @HttpCode(201)


suggestion: Mais du coup on peut utiliser les constantes des codes HTTP ici, non ? 😏

StephaneTrebel · 2026-07-15T12:27:20Z

+        hash: 'hash-2',
+      })
+
+      const result = await service.create({ name: 'my-token', expirationDate: '2099-01-01' }, userId)


thought: Je me demande toujours, quand il s'agit de dates, si on est timezone-safe 🤔

D'autant que n'importe qui peut appeler l'API (légitimement j'entends)

StephaneTrebel · 2026-07-15T12:35:57Z

+      const password = generateRandomPassword(48, 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-')
+      const salt = randomBytes(16).toString('hex')
+      const derivedKey = scryptSync(password, salt, 64).toString('hex')
+      const hash = `${salt}:${derivedKey}`


suggestion: Bon ben ça fait deux, là, non ? 😁

github-advanced-security AI found potential problems Jun 30, 2026

View reviewed changes

Comment thread apps/server-nestjs/src/modules/admin-token/admin-token.service.ts Fixed

Comment thread apps/server-nestjs/src/modules/user-tokens/user-tokens.service.ts Fixed

shikanime force-pushed the shikanime/push-uotmotuknkvy branch from a9a75b7 to 64a5234 Compare June 30, 2026 10:02

github-advanced-security AI found potential problems Jun 30, 2026

View reviewed changes

shikanime force-pushed the shikanime/push-uotmotuknkvy branch 10 times, most recently from b37e308 to 0331d48 Compare July 1, 2026 09:54

github-code-quality Bot found potential problems Jul 1, 2026

View reviewed changes

Comment thread ...odules/infrastructure/auth/keycloak-secret-provider/keycloak-secret-provider.service.spec.ts Fixed

Comment thread apps/server-nestjs/src/modules/registry/registry-client.service.spec.ts Fixed

shikanime force-pushed the shikanime/push-uotmotuknkvy branch from 0331d48 to c53cb23 Compare July 1, 2026 10:19

github-code-quality Bot found potential problems Jul 1, 2026

View reviewed changes

Comment thread apps/server-nestjs/src/modules/gitlab/gitlab-client.service.ts Fixed

Comment thread apps/server-nestjs/src/modules/gitlab/gitlab.service.ts Fixed

shikanime force-pushed the shikanime/push-uotmotuknkvy branch 2 times, most recently from 09f3402 to b667443 Compare July 1, 2026 11:29

github-code-quality Bot found potential problems Jul 1, 2026

View reviewed changes

Comment thread apps/server-nestjs/src/modules/project-roles/project-roles.service.ts Fixed

shikanime force-pushed the shikanime/push-uotmotuknkvy branch 2 times, most recently from 1b31261 to f16a730 Compare July 1, 2026 12:00

shikanime changed the title ~~refactor(server-nestjs): migrate project hook~~ refactor(user-tokens): migrate from server Jul 1, 2026

shikanime force-pushed the shikanime/push-uotmotuknkvy branch 4 times, most recently from cecad1b to 10b4770 Compare July 1, 2026 13:35

github-actions Bot added the built label Jul 1, 2026

shikanime force-pushed the shikanime/push-uotmotuknkvy branch 2 times, most recently from 0eb3e93 to 43d21dc Compare July 1, 2026 13:56

shikanime force-pushed the shikanime/push-uotmotuknkvy branch from 2e5abec to 09ac7ac Compare July 3, 2026 14:06

shikanime force-pushed the shikanime/push-uotmotuknkvy branch from 09ac7ac to 7b8a3c7 Compare July 3, 2026 15:31

shikanime force-pushed the shikanime/push-uotmotuknkvy branch from 7b8a3c7 to a1e4df7 Compare July 7, 2026 10:46

shikanime force-pushed the shikanime/push-uotmotuknkvy branch from a1e4df7 to 125804c Compare July 8, 2026 08:32

shikanime force-pushed the shikanime/push-uotmotuknkvy branch from 125804c to aa3de07 Compare July 8, 2026 09:12

shikanime force-pushed the shikanime/push-uotmotuknkvy branch from aa3de07 to e5ce635 Compare July 8, 2026 09:41

shikanime force-pushed the shikanime/push-uotmotuknkvy branch 2 times, most recently from 60bbb8e to d7d0c3b Compare July 8, 2026 09:53

shikanime requested a review from KepoParis July 8, 2026 10:16

shikanime force-pushed the shikanime/push-uotmotuknkvy branch from d7d0c3b to 6bfdd13 Compare July 13, 2026 09:20

shikanime force-pushed the shikanime/push-uotmotuknkvy branch from 6bfdd13 to b5b5107 Compare July 13, 2026 12:38

shikanime force-pushed the shikanime/push-uotmotuknkvy branch from b5b5107 to 3b957fa Compare July 13, 2026 13:30

refactor(user-tokens): migrate from server

259a636

Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio> Change-Id: I5b6db65fcf411b3bfddc4a72430b8d4c6a6a6964

StephaneTrebel self-requested a review July 15, 2026 12:05

shikanime force-pushed the shikanime/push-uotmotuknkvy branch from 3b957fa to 259a636 Compare July 15, 2026 12:16

StephaneTrebel requested changes Jul 15, 2026

View reviewed changes

	\| Approche migration \| Bottom-up (feuilles d'abord, puis remonttee vers les modules couples) \|
	\| Approche migration \| Bottom-up (feuilles d'abord, puis remontée vers les modules couples) \|

	return this.service.list(withRevoked !== undefined && withRevoked !== 'false')
	return this.service.list(withRevoked === 'true')

Uh oh!

Conversation

shikanime commented Jun 30, 2026

Issues liées

Quel est le comportement actuel ?

Quel est le nouveau comportement ?

Cette PR introduit-elle un breaking change ?

Autres informations

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 15, 2026

Uh oh!

cloud-pi-native-sonarqube Bot commented Jul 15, 2026

Quality Gate passed

Issues

Measures

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!