Skip to content

fix: cleanly close the connect tunnel - #119

Draft
agrimault-dinum wants to merge 1 commit into
mainfrom
fix/clean-tcpstream-shutdown
Draft

fix: cleanly close the connect tunnel#119
agrimault-dinum wants to merge 1 commit into
mainfrom
fix/clean-tcpstream-shutdown

Conversation

@agrimault-dinum

Copy link
Copy Markdown
Collaborator

No description provided.

@rlahfa-dinum

Copy link
Copy Markdown
Collaborator

If you want to salvage this to solve #50, feel free. Otherwise, I will let you close it.

@agrimault-dinum

Copy link
Copy Markdown
Collaborator Author

I began this code to fix #50 but thought it might be useful with regards to the bug we were experiencing.

The question I keep pondering is: should we actually mute the warning? I am hesitating here, since the protocol inside the tls tunnel might be vulnerable to truncation. Since we don't inspect, we can't differentiate between legitimate and not. How about putting the error as a warning as subsystem=proxy_access?

In order to fix #50:

  • add a e2e test that we correctly propagate the close_notify
  • do something about the error

@rlahfa-dinum

Copy link
Copy Markdown
Collaborator

I began this code to fix #50 but thought it might be useful with regards to the bug we were experiencing.

The question I keep pondering is: should we actually mute the warning? I am hesitating here, since the protocol inside the tls tunnel might be vulnerable to truncation. Since we don't inspect, we can't differentiate between legitimate and not. How about putting the error as a warning as subsystem=proxy_access?

In order to fix #50:

  • add a e2e test that we correctly propagate the close_notify
  • do something about the error

The way I would fix this is I would write a truncation attack as an E2E test and verify things behave reasonably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants