fix(release): publish npm with trusted publishing - #26
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe release workflow's Node.js version is bumped from 22 to 24, and the npm publish step drops the ChangesRelease Workflow and Setup Docs
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publish npm releases through npm Trusted Publishing/OIDC instead of an npm token.
Details
NODE_AUTH_TOKENfrom the publish step so npm can use the configured Trusted Publisher.^11.15.0, which satisfies npm Trusted Publishing requirements.set -o pipefailso publish failures are not hidden bytee.NPM_TOKEN.Related Issues
Related to #XXXX
How to Validate
bun run check && bun test.bun run build && bun test tests/e2e/.publish-npmuses npm 11+ withoutNODE_AUTH_TOKEN.Pre-Merge Checklist
Code Quality
bun run build)bun run typecheck)bun run lint)bun test)Documentation
Commit Standards
Platform Validation
Summary by CodeRabbit
Documentation
Bug Fixes