fix: official letter openings not masked as PIB (v2.6.9)#42
Merged
Conversation
'Повідомляємо Вам, що ...' was treated as 'Surname Name'. Reject 1st/2nd-person-plural verb endings (-ємо/-имо/-емо/-єте/-ите/-ете) in looks_like_name; add pronouns Вам/Вами/Ваш and common official verbs to EXCLUDE_WORDS. Real PIB after such phrases still masked. +3 tests. https://claude.ai/code/session_01XT6iUWaQgahXDB9TWX9Bq7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Повідомляємо Вамwas masked as a PIBIn
Повідомляємо Вам, що відповідно до пункту 15 розділу XII Інструкції …the parser saw two Title-Case words in a row and masked them as "Surname Name" →Повритулляємо Володимир, що ….Fix
looks_like_namerejects words with 1st/2nd-person-plural verb endings (-ємо,-имо,-емо,-єте,-ите,-ете) — no Ukrainian name/surname ends this way.Вам/Вами/Ваш(-а/-е)and common official verbs (Повідомляємо,Просимо,Направляємо,Надаємо) added toEXCLUDE_WORDS(onlyВасwas there before).Повідомляємо, що сержант Коваленко Марія Іванівна прибула→ phrase kept, rank+PIB masked.Test plan
https://claude.ai/code/session_01XT6iUWaQgahXDB9TWX9Bq7
Generated by Claude Code