test: use subprocess.check_output() instead of subprocess.run() - #37
Merged
Conversation
- Replace all subprocess.run() calls with subprocess.check_output() - Remove explicit returncode == 0 assertions (implicit in check_output) - Simplify TestOpenStackCloud tests by not catching CalledProcessError, but instead throwing it up the stack - Catch errors caused by the corresponding API endpoints not being available, and issue warnings for those instead. Assisted-by: opencode/qwen3.6-35b-a3b-fp8
fghaas
force-pushed
the
test-subprocess-check-output
branch
from
September 2, 2026 08:50
fe0167b to
0d804a2
Compare
NamrataSitlani
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CalledProcessError, but instead throwing it up the stack
available, and issue warnings for those instead.
Assisted-by: opencode/qwen3.6-35b-a3b-fp8