DLS I16 loader#110
Merged
Merged
Conversation
Fix geometry in geometry.py, remove changes to loader. Also, improved docs.
clatlan
approved these changes
May 10, 2026
ruff format and ruff check --fix
ruff format and ruff check --fix
Contributor
Author
|
Changes made above. Thanks for the suggestions about multiple axes - these will have to wait for a future PR, along with cluster submission changes. I suggest this is merged as is as it works for standard rocking scans in the vertical geometry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of CDIUtils for the I16 beamline at Diamond Light Source.
prepare_bcdi_notebooks.pyscript to allow this to be run (it will run automatically if the instrument environment variable is present).The notebooks run on the beamline in a prepared python environment including PyNX.
Still todo: I need to make some changes to allow cluster submission at DLS.