RFC: start integrating with libosinfo for URLs - #247
Open
ptoscano wants to merge 2 commits into
Open
Conversation
Owner
|
I'm quite interested in this topic; it has been on the Oz TODO list for many years. From that perspective, thanks a lot for kicking this off. I will mention two things:
I'll definitely take a look at this in the New Year. |
Create a new get_osinfo method in the module of every OS, with a global factory method in GuestFactory: it makes it possible to associate a short ID of libosinfo OSes to each of the supported OSes in oz. Signed-off-by: Pino Toscano <ptoscano@redhat.com>
Try to use libosinfo (if available) to get the URLs of install trees and ISOs of the supported OSes, using a libosinfo short ID provided by all the OS classes. Add <osinfo> and <variant> child tags of <os> to override (or set) the short ID, and its libosinfo variant. This makes the <url> and <iso> child tags of <install> optional, as they can be determined automatically from libosinfo, at least from the majority of cases. Signed-off-by: Pino Toscano <ptoscano@redhat.com>
Contributor
Author
|
Hi Chris, any news on this front? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the start of integration with libosinfo, at least for getting the URLs of install trees and ISOs (#38). The libosinfo usage is still optional, so without it URLs are still required. The implementation allow changing/setting the libosinfo short ID, and the variant for it (some distros use it).
The implementation and the UX may not be the best, but that can be improved :) So let's start a discussion about libosinfo, and whether can be unconditionally used, and how.