[28/36] Add OC-140 WebSocket lifecycle task - #60
Conversation
2e387f4 to
4030efd
Compare
eb4afe7 to
bc22156
Compare
|
Verdict: approve with nits. The task doc is internally consistent (goal, acceptance, tests, out-of-scope all align) and its acceptance criteria are a good yardstick, in fact two of them (secret redaction, no leaked listeners) are exactly where the implementation PR falls short, so the doc is stronger than the code that implements it. One nit: AGENT_PROGRESS says OC-130 accepted while README calls OC-130 a follow-up task, both edited in this PR, pick one. |
|
Reviewed this as the planning-only PR for OC-140. The task document is internally consistent and is the acceptance contract for the implementation. The secret-redaction and listener-cleanup observations concern implementation PR #61; they are not missing implementation from this planning branch, and I am assessing them on PR #61. The OC-130 status mismatch is valid on this intermediate branch, but it is already fixed later in the stack by PR #66, commit I tested a duplicate correction on PR #60 before pushing it. The immediate edge PR #60 -> PR #61 remained clean, but the stack-tip simulations PR #60 -> PR #71 and PR #60 -> PR #72 both produced a conflict in I also corrected the malformed base/head placeholders in this PR description. The task links resolve, PR #60 and immediate child PR #61 are live |
Summary
Adds the supervisor planning task for first-class WebSocket connection lifecycle UX, including editor, CodeLens, status bar, and Copilot tool expectations.
Stack
Base:
feature/oc-130-protocol-layout-stability(PR #59)Head:
supervisor/add-websocket-lifecycle-taskImmediate child:
feature/oc-140-websocket-lifecycle-ux(PR #61)Validation
npm run compilenpm testnpm run buildmissio-0.8.0.vsixmissio.missio@0.8.0locally