Skip to content

pinctrl: Fix early return in sky1_pinconf_group_dbg_show#52

Open
USAVault wants to merge 3 commits into
cixtech:mainfrom
USAVault:pinctrl-sky1-fix-broken-return-in-sky1_pinconf_group_dbg_show
Open

pinctrl: Fix early return in sky1_pinconf_group_dbg_show#52
USAVault wants to merge 3 commits into
cixtech:mainfrom
USAVault:pinctrl-sky1-fix-broken-return-in-sky1_pinconf_group_dbg_show

Conversation

@USAVault

@USAVault USAVault commented Jul 15, 2026

Copy link
Copy Markdown

In sky1_pinconf_get(): add a guard for pin_regs[pin_id] == -1 and return -EINVAL, without it, unconfigured pins lead to an invalid readl(base + 0xFFFFFFFF) access

In sky1_pinconf_group_dbg_show(): the unconditional return inside the loop was intended to be conditional. I believe it should have been if (ret) return, as the extra indent level suggests the author’s intent, so the logic is updated to match the mainline imx_pinconf_group_dbg_show pattern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant