UNC Path and Share Arguments to Snaffle Specific Shares#46
Open
camlischke1 wants to merge 2 commits into
Open
Conversation
added 2 commits
June 3, 2026 10:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
Added two new arguments to the argument parser:
-s/--shares: accepts a comma-separated list of share names to scan (e.g.hr,documents,test)--unc: accepts a UNC path in\\server\shareformat to target a specific share directlyBoth arguments feed into a unified
options.targetsandoptions.shareslist, so the rest of the codebase handles them consistently regardless of how the user provided their input.💭 Motivation and context
Previously, SnafflePy had no way to scope a scan to specific shares or target a single share via UNC path — it would always attempt to scan all discovered shares. This change allows users to narrow the scope of a scan, which is useful when:
🧪 Testing
The following cases were tested manually:
Comma-separated shares:
Single share:
UNC path only:
UNC path combined with -s: