Skip to content

Refresh HTML converter snapshot #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubes4 merged 1 commit into from
Jun 7, 2026
Merged

Refresh HTML converter snapshot #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

53 changes: 53 additions & 0 deletions vendor_prefixed/chubes4/html-to-blocks-converter/includes/class-transform-registry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -876,6 +876,10 @@ private static function get_button_transforms()
return self::is_static_visual_button_container($element);
}, 'transform' => function ($element) {
return self::create_static_visual_button_group($element);
}), array('blockName' => 'core/group', 'priority' => 8, 'selector' => 'button', 'isMatch' => function ($element) {
return self::is_static_toggle_button_chrome($element);
}, 'transform' => function ($element) {
return self::create_static_toggle_button_group($element);
}), array('blockName' => 'core/paragraph', 'priority' => 8, 'selector' => 'button', 'isMatch' => function ($element) {
return self::is_static_navigation_toggle_button($element);
}, 'transform' => function ($element) {
Expand Down Expand Up @@ -1070,6 +1074,55 @@ private static function is_static_visual_button($element): bool
$class_name = $element->has_attribute('class') ? $element->get_attribute('class') : '';
return \preg_match('/(?:^|[-_\s])(?:tabs?|chips?|filters?|pills?|segmented|selector|use[-_]?case)(?:$|[-_\s])/i', $class_name) === 1;
}
/**
* Checks whether a button is inert navigation toggle chrome.
*
* @param HTML_To_Blocks_HTML_Element $element Element to inspect.
* @return bool True when the button can safely become native visual chrome.
*/
private static function is_static_toggle_button_chrome($element): bool
{
if ('BUTTON' !== $element->get_tag_name()) {
return \false;
}
if ($element->has_attribute('form') || $element->has_attribute('name') || $element->has_attribute('value')) {
return \false;
}
$type = \strtolower(\trim((string) ($element->get_attribute('type') ?? '')));
if ('' !== $type && 'button' !== $type) {
return \false;
}
$class_name = $element->has_attribute('class') ? $element->get_attribute('class') : '';
if (\preg_match('/(?:^|[-_\s])(?:nav[-_\s]?toggle|menu[-_\s]?toggle|hamburger)(?:$|[-_\s])/i', $class_name) !== 1) {
return \false;
}
$children = $element->get_child_elements();
if (empty($children)) {
return \trim($element->get_text_content()) === '';
}
foreach ($children as $child) {
if (!\in_array($child->get_tag_name(), array('SPAN', 'DIV'), \true)) {
return \false;
}
if (self::is_empty_element($child)) {
continue;
}
if (!self::class_matches($child, '/(?:^|\s)sr-only(?:\s|$)/i') || array() !== $child->get_child_elements()) {
return \false;
}
}
return \true;
}
/**
* Creates native visual chrome for an inert navigation toggle button.
*
* @param HTML_To_Blocks_HTML_Element $element Button element.
* @return array Block array.
*/
private static function create_static_toggle_button_group($element): array
{
return HTML_To_Blocks_Block_Factory::create_block('core/group', self::get_common_layout_attributes($element));
}
/**
* Creates a native group from a static visual button row.
*
Expand Down
13 changes: 13 additions & 0 deletions vendor_prefixed/chubes4/html-to-blocks-converter/tests/smoke-static-site-chrome.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,19 @@ function html_to_blocks_smoke_block_names(array $blocks): array
$assert(\str_contains($salt_star_serialized, 'href="#our-bakes"'), 'salt-star-nav-preserves-our-bakes-href', $salt_star_serialized);
$assert(\str_contains($salt_star_serialized, 'href="#visit"'), 'salt-star-nav-preserves-visit-href', $salt_star_serialized);
$assert(\str_contains($salt_star_serialized, 'href="#order"'), 'salt-star-nav-preserves-order-href', $salt_star_serialized);
$restaurant_nav_html = <<<HTML
<nav class="nav container" aria-label="Primary navigation">
<a class="brand" href="index.html"><img src="assets/img/ember-rye-mark.svg" alt="" width="46" height="46"><span><strong>Ember &amp; Rye</strong><small>Wood-Fired Pizza</small></span></a>
<button class="nav-toggle" type="button" aria-expanded="false" aria-controls="primary-menu"><span class="sr-only">Toggle navigation</span><span></span><span></span><span></span></button>
<ul class="nav-links"><li><a href="menu.html">Menu</a></li><li><a href="reservations.html">Reservations</a></li></ul>
</nav>
HTML;
$restaurant_nav_serialized = serialize_blocks(html_to_blocks_raw_handler(['HTML' => $restaurant_nav_html]));
$assert(!\str_contains($restaurant_nav_serialized, '<!-- wp:html -->'), 'restaurant-nav-toggle-avoids-core-html-fallback', $restaurant_nav_serialized);
$assert(\str_contains($restaurant_nav_serialized, '<nav class="wp-block-group nav container" aria-label="Primary navigation">'), 'restaurant-nav-wrapper-survives', $restaurant_nav_serialized);
$assert(\str_contains($restaurant_nav_serialized, 'class="wp-block-group nav-toggle"'), 'restaurant-nav-toggle-becomes-native-chrome', $restaurant_nav_serialized);
$assert(\str_contains($restaurant_nav_serialized, '<a class="brand" href="index.html">'), 'restaurant-nav-brand-link-survives', $restaurant_nav_serialized);
$assert(\str_contains($restaurant_nav_serialized, 'class="wp-block-list nav-links"'), 'restaurant-nav-links-survive', $restaurant_nav_serialized);
$studio_code_nav_serialized = serialize_blocks(html_to_blocks_raw_handler(array('HTML' => '<nav><div class="nav-logo"><div class="dot"></div>Studio Code</div></nav>')));
$assert(!\str_contains($studio_code_nav_serialized, '<!-- wp:html -->'), 'studio-code-nav-logo-dot-avoids-core-html', $studio_code_nav_serialized);
$assert(\str_contains($studio_code_nav_serialized, '<nav class="wp-block-group">'), 'studio-code-nav-wrapper-survives', $studio_code_nav_serialized);
Expand Down
Loading