fix(ci): make realtime worker deploy actually run#3
Merged
Conversation
Co-authored-by: Chaitanya Mittal <chtnnh@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Deploy workflow triggered correctly after CI on
mainbut failed in ~16s. Two bugs:ERR_PNPM_INVALID_DEPLOY_TARGET … requires one parameter—pnpm --filter @together/realtime deployresolves to pnpm's built-indeploycommand, not the package'sdeployscript. Fixed by usingpnpm --filter @together/realtime run deploy.CLOUDFLARE_API_TOKEN/CLOUDFLARE_ACCOUNT_ID— the secrets were added as Environment secrets, but the job didn't declare anenvironment:, so they injected as empty strings. Fixed by addingenvironment: productionto the job.Action required
The job now reads secrets from a GitHub Environment named
production. Make sure that's whereCLOUDFLARE_API_TOKENandCLOUDFLARE_ACCOUNT_IDlive (Settings → Environments → production). If you named the environment something else, change the oneenvironment:line to match.Testing
pnpm --filter @together/realtime deploy→ERR_PNPM_INVALID_DEPLOY_TARGET;pnpm --filter @together/realtime run deploy→ runswrangler deploy --env production.deploy.ymlvalidated as well-formed YAML.main, the next green CI run will trigger Deploy with the corrected command + environment.