Remove --sse-buffer flag, default to large buffer sizes - #74
Conversation
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe ChangesSSE buffer configuration removal
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Remove the
--sse-bufferCLI flag andSseBufferModeenum. The generated SSE parser now always uses large buffer sizes (256KB lines, 1MB events) instead of defaulting to small (8KB lines, 64KB events).Motivation
Puny (https://github.com/christianhelle/puny) was hitting the 8KB/64KB SSE buffer limit when parsing server-sent events. Rather than adding
--sse-buffer largeto Puny's openapi2zig invocation, the rational default for all generated clients is the large buffer.Changes
SseBufferModeenum,--sse-bufferarg parsing,parseSseBufferMode(), and usage text fromcli.zigsse_bufferfield fromCliArgsruntime_generator.zigandapi_generator.zigsse_bufferparameter fromRuntimeGenerator.init()calls ingenerator.zigandlib.zigREADME.mdanddocs/index.htmlto remove--sse-bufferreferencesTest seams
zig build testparse generate silently ignores --sse-buffer flagdocuments the removalSummary by CodeRabbit
Documentation
--sse-bufferoption.Bug Fixes