Skip to content

fix: harden watch party diagnostics and recovery - #76

Merged
chrisae9 merged 1 commit into
devfrom
fix/watch-party-review-followups
Sep 8, 2026
Merged

fix: harden watch party diagnostics and recovery#76
chrisae9 merged 1 commit into
devfrom
fix/watch-party-review-followups

Conversation

@chrisae9

@chrisae9 chrisae9 commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Summary

Prevent a previous source’s buffering interval from producing a quality recommendation for a new video, and exclude intentional disconnects from connection-failure reports. Normalize Plex identifiers for participant timing and bound health metrics before broadcasting them.

Verification

Lint, production build, and all 536 tests pass (153 server/Node, 383 frontend). Production dependency audit reports zero vulnerabilities. Regression coverage includes source changes during buffering, intentional disconnects, failed room creation, participant timing boundaries, live guest preset updates, malformed diagnostics, and invalid presets.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 40 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0154f4e2-8551-4ae1-a62e-968009bfd917

📥 Commits

Reviewing files that changed from the base of the PR and between 8cc4c97 and 2a3234c.

📒 Files selected for processing (10)
  • packages/syncloungeserver/src/socketserver/playbackdiagnostics.js
  • src/__tests__/participant-health.test.js
  • src/__tests__/room-creation-navigation.test.js
  • src/__tests__/slplayer-speed-seek.test.js
  • src/__tests__/socket-diagnostics.test.js
  • src/components/UserList.vue
  • src/socket.js
  • src/store/modules/slplayer/actions.js
  • test/playbackdiagnostics.test.js
  • test/socket-validation.test.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chrisae9
chrisae9 merged commit 3a71bd6 into dev Sep 8, 2026
9 checks passed
@chrisae9
chrisae9 deleted the fix/watch-party-review-followups branch September 8, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant