[WIP] feat: add newsletter module with subscriber management and campaign c… - #96
Draft
mrkpatchaa wants to merge 8 commits into
Draft
[WIP] feat: add newsletter module with subscriber management and campaign c…#96mrkpatchaa wants to merge 8 commits into
mrkpatchaa wants to merge 8 commits into
Conversation
choyiny
added
minor
This commit introduces a detailed adversarial review of the newsletter spec, highlighting critical and high-priority findings related to delivery idempotency, campaign fan-out, event deduplication, subscriber management, and more. The review outlines necessary corrections, additional corrections, and required test additions to ensure compliance with Cloudflare platform constraints and best practices for data integrity, privacy, and operational efficiency. Key findings include: - Delivery idempotency issues and the need for a robust outbox pattern. - Resumable job patterns for campaign fan-out and CSV imports. - Unique constraints for event tracking to prevent data inflation. - Authorization requirements and privacy considerations for subscriber data. The review emphasizes the importance of addressing these findings before implementation begins to ensure a reliable and compliant newsletter service.
…preview, and input sanitization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.