Refactor requirements handling in setup.py - #22
Merged
sw005320 merged 3 commits intoAug 10, 2026
Conversation
Refactored requirements handling by adding a read_requirements function to read from requirements.txt and removed pkg_resources dependency.
Contributor
|
Thanks for your PR. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates setup.py to stop using pkg_resources (removed in newer setuptools) and instead read dependencies directly from requirements.txt, restoring install/build compatibility.
Changes:
- Added
read_requirements()to load requirements fromrequirements.txtviapathlib.Path. - Removed the
pkg_resources.parse_requirements(...)dependency parsing logic. - Updated
install_requiresconstruction to concatenate the dynamically built list withread_requirements()output.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
This is handled by copilot. |
Contributor
Contributor
|
Thanks, @alexanderwerning! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored requirements handling by adding a read_requirements function to read from requirements.txt and removed pkg_resources dependency.
setuptools 82 removed
pkg_resources,importlibis recommended to access files in the package. The install is currently failing, this fixes it.This caused issues in packages downstream: fgnt/meeteval#131