feat(request_forwarder): Add config option to set DNS cache TTL#243
Draft
andrerenard wants to merge 1 commit intomainfrom
Draft
feat(request_forwarder): Add config option to set DNS cache TTL#243andrerenard wants to merge 1 commit intomainfrom
andrerenard wants to merge 1 commit intomainfrom
Conversation
|
This pull request introduces 1 alert when merging 156f784 into 195e359 - view on LGTM.com new alerts:
|
andrerenard
force-pushed
the
ar/enable_dns_cache
branch
from
156f784 to
b6add7c
Compare
jrs65
approved these changes
Jul 18, 2022
Contributor
jrs65
left a comment
jrs65
left a comment
There was a problem hiding this comment.
A few optional suggestions.
| f"Failed parsing value 'timeout' ({self.config['timeout']})." | ||
| ) from e | ||
| try: | ||
| dns_cache_ttl = str2total_seconds(self.config["dns_cache_ttl"]) |
Contributor
There was a problem hiding this comment.
I think this one should probably have a default value rather than throwing a ConfigError if it's missing.
| "host": "localhost", | ||
| "port": 12055, | ||
| "log_level": "DEBUG", | ||
| "dns_cache_ttl": 60, |
Contributor
There was a problem hiding this comment.
You might use a string like 60s or 1m to exercise the parsing logic.
Contributor
|
@andrerenard I think this one can get finished off now #242 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked because of issues running unit tests, will convert to full PR once #242 is merged and I can verify the tests pass.
This change will also require a change to the coco config in ch_ansible.