fix: check StateDiagram inheritance semantically, not syntactically - #265
Open
spirifoxy wants to merge 1 commit into
Open
fix: check StateDiagram inheritance semantically, not syntactically#265spirifoxy wants to merge 1 commit into
spirifoxy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[StateDiagram]is silently ignored when the attributed record's base type is not literally namedLogicBlockStateand that base is not declared in the same file. The generator falls through to the unrelatedIsLogicBlockCandidatepath and writes a stub diagram containing only the initial state.Reproduction
Gives
Changing
: SharedBaseto: LogicBlockStateproduces the correct diagram with every state and transition.Fix
Move the inheritance check from the syntax predicate into the semantic transform .
IsStateDiagramCandidatenow only checks for the attribute.DiscoverStateGraphverifies inheritance viaCodeService.GetAllBaseTypes, the same helper it already uses a few lines further down, and returnsnullif the type is not a logic block state.