gradle: Clean up go files; fix build on Windows - #330
Merged
Conversation
chenxiaolong
force-pushed
the
build-clean-windows
branch
from
August 20, 2026 05:11
6dd399c to
7048d28
Compare
Builds on Windows are reproducible as long as core.autocrlf=false and core.eol=lf are set before cloning the repo. Otherwise, Syncthing's GUI assets will have CRLF line endings. The gradle scripts now also have to strip out the .comment ELF section since the same version of the NDK writes different comment strings on different host platforms. Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
force-pushed
the
build-clean-windows
branch
from
August 20, 2026 14:04
7048d28 to
6dc7081
Compare
chenxiaolong
added a commit
that referenced
this pull request
Aug 20, 2026
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on Windows are reproducible as long as
core.autocrlf=falseandcore.eol=lfare set before cloning the repo. Otherwise, Syncthing's GUI assets will have CRLF line endings.The gradle scripts now also have to strip out the
.commentELF section since the same version of the NDK writes different comment strings on different host platforms.