Skip to content

Use gshash for Ghost KV Cache: apply crc32 to std::hash<std::string_view> #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenhao-ye merged 2 commits into from
Aug 21, 2025
Merged

Use gshash for Ghost KV Cache: apply crc32 to std::hash<std::string_view> #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2b6aca
use gshash for more robust hash distribution
chenhao-ye Aug 19, 2025
cde32ce
add const
chenhao-ye Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/gcache/ghost_kv_cache.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ struct GhostKvMeta {
* pair can be variable-length. By default support sampling (non-sampling
* version can be acquired by setting SampleShift=0)
*/
template <uint32_t SampleShift = 5, typename Hash = std::hash<std::string_view>,
template <uint32_t SampleShift = 5, typename Hash = gshash,
typename SizeType = uint32_t, typename HashType = uint32_t>
class SampledGhostKvCache {
SampledGhostCache<SampleShift, idhash, GhostKvMeta<SizeType>, SizeType,
Expand Down
8 changes: 8 additions & 0 deletions include/gcache/hash.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,12 @@ struct murmurhash {
uint32_t operator()(uint32_t x) const noexcept { return murmurhash_u32(x); }
};

/* Hash for string_view */

struct gshash { // default string hash function for gcache
uint32_t operator()(const std::string_view x) const noexcept {
return crc32_u32(0x537, std::hash<std::string_view>{}(x));
}
};

} // namespace gcache