Feature/image position - Add per-image position suffix for slide layouts#33
Open
LeonFooC wants to merge 2 commits into
Open
Feature/image position - Add per-image position suffix for slide layouts#33LeonFooC wants to merge 2 commits into
LeonFooC wants to merge 2 commits into
Conversation
# Conflicts: # packages/client/src/components/SlideContent.tsx # packages/client/src/hooks/useSocket.ts # packages/client/src/index.css # packages/client/src/views/InstructorView.tsx # packages/client/src/views/PresentationView.tsx # packages/client/src/views/StudentView.tsx # packages/server/src/parser.ts # packages/server/src/print-mdq.ts # packages/server/src/socket.ts # packages/shared/src/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @chektien , I tried extending the image position feature, adding a suffix that allows you to indicate the position of the image.
I've compiled a implementation log which contains updates, changes, and bug information, mdq-implementation-log.md.
Adds an optional
-right/-left/-top/-bottom/-background[:N]suffix to slide-image markdown so authors can place the visual relative to the body text without leaving markdown.Examples
-backgroundtakes an optional opacity in[0, 1], default0.3.-right).Coexists with
slideLiveEmbed: when a slide sets both, the live embed wins and the static media grid is skipped, so position is only consulted on non-embed slides.