Add respond_to_missing? to ResourceMatcher#42
Open
tas50 wants to merge 1 commit into
Open
Conversation
ResourceMatcher#method_missing implements the dynamic `with_*` matcher sugar but had no matching respond_to_missing?, so `respond_to?(:with_x)` returned false and the object misrepresented its interface to introspection and serialization. Add respond_to_missing? mirroring the method_missing pattern, following the same approach already used in SoloRunner. Signed-off-by: Tim Smith <tsmith84@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResourceMatcher#method_missingprovides the dynamicwith_*(value)matcher sugar, but there was no correspondingrespond_to_missing?. As a resultmatcher.respond_to?(:with_owner)returnedfalseeven though the call works — the object lied about its own interface, which trips uprespond_to?-based introspection and serialization libraries.This adds
respond_to_missing?mirroring themethod_missingregex, the same pattern already used inSoloRunner#respond_to_missing?(solo_runner.rb).Testing
with_*methods and that it does not claim unrelated methods.bundle exec rspec spec/unit/→163 examples, 0 failures.cookstyle --chefstyle -c .rubocop.yml→ no offenses.Note
This touches
spec/unit/matchers/resource_matcher_spec.rb, which is also rewritten by #31 (the rspec-expectations fix replaced itspendingstub). Whichever merges first, the other needs a trivial merge of the two example groups.