Replace Proc.new with proc#36
Open
tas50 wants to merge 1 commit into
Open
Conversation
`Proc.new` without a block is deprecated, and the bare `Proc.new` constructor offers no advantage over the `proc` Kernel method. Switch the three remaining call sites to `proc` for a clearer, future-proof idiom. Signed-off-by: Tim Smith <tsmith84@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the three remaining uses of
Proc.newwith theprocKernel method:lib/chefspec.rb(define_matcher)lib/chefspec/stubs/stub.rb(and_raise)lib/chefspec/matchers/notifications_matcher.rb(matches?)Proc.newis a legacy idiom — calling it without a block was deprecated and removed in modern Ruby, and the explicit constructor offers nothing overproc { ... }. This is a behavior-preserving readability/future-proofing cleanup.Testing
bundle exec rspec spec/unit/→162 examples, 0 failures.cookstyle --chefstyle -c .rubocop.ymlon the changed files → no offenses.