Conversation
missytake
left a comment
There was a problem hiding this comment.
I don't think this approach would work, see my comment. In any case, this PR needs a test.
2e2e6cd to
0bfc671
Compare
0bfc671 to
ada0060
Compare
ada0060 to
9dac959
Compare
9dac959 to
43590d3
Compare
43590d3 to
b197edf
Compare
b197edf to
726837f
Compare
ae0ef53 to
40ee20f
Compare
40ee20f to
d0d5635
Compare
1176503 to
a6e7a87
Compare
a6e7a87 to
89bfab6
Compare
|
@j-g00da in the spirit of clean-up april, what's the status of this PR? |
CI fails because ci-chatmail runs old filtermail version, it has to be upgraded. Other than that this is ready. |
I upgraded ci-chatmail.testrun.org to main :) weirdly, I can't restart the failed CI jobs, maybe you can rebase on main to re-trigger the CI? |
89bfab6 to
3dea2a1
Compare
3dea2a1 to
91e8d2a
Compare
Closes #873 Signed-off-by: Jagoda Ślązak <jslazak@jslazak.com>
91e8d2a to
5cd887f
Compare
|
|
ah yes, it is - it runs the tests with |
|
I wonder if this will require further changes after #917 |
Closes #873