fix: Re-add oauth2 to serialized structs - #8464
Merged
Merged
Conversation
Followup to #8431: Re-dd `oauth2` to the two structs that serialized and sent over the wire. This solves an incompatibility problem where transports could not be synced to older versions of DC, and profiles could not be transferred, because the deserializer expected the field to be present. I now added `#[serde(default)]`, so that with this PR, Delta Chat will be compatible with both v2.56 and with older versions. Not tested yet.
missytake
approved these changes
Jul 25, 2026
missytake
left a comment
missytake
left a comment
Contributor
There was a problem hiding this comment.
This means that backups from 2.56 can be imported - but backups from this branch can not be imported into 2.56 I assume?
Collaborator
Author
|
I didn't test it yet, but theoretically this should be compatible with both 2.56 and older versions in both directions. |
Collaborator
Author
|
I tested that with this PR, it works fine to transfer a newly created profile from and to 2.56 and 2.53.1 in both directions. Note the following will still fail:
I.e. if any transport was added in 2.56, then transferring the profile to older versions will fail, even if you updated to this PR here in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #8463
Followup to #8431: Re-dd
oauth2to the two structs that serialized and sent over the wire. This solves an incompatibility problem where transports could not be synced to older versions of DC, and profiles could not be transferred, because the deserializer expected the field to be present.I now added
#[serde(default)], so that with this PR, Delta Chat will be compatible with both v2.56 and with older versions.Not tested yet.