fix(onboarding): show workers-only engines as disabled rows instead of hiding them - #415
Open
Vasilispapg wants to merge 2 commits into
Open
Conversation
…f hiding them The engine step filtered to inbox-capable providers, so Copilot and Kimi simply vanished — which read as "not supported at all" (issue chaitanyagiri#355), when the real constraint is narrower: a print-mode / bridge-less CLI can be hired as a worker but cannot run Michael, who must drain hive mail. List every preset engine instead: the god-eligible set stays selectable (same order as before), and the workers-only engines render at the bottom as disabled rows — muted, radio disabled, a WORKERS ONLY badge, and a one-line hint saying why and that hiring them as workers still works. `custom` stays hidden (bring-your-own command, not a preset engine). New onboardingEngineChoices() in the config store keeps the split in one tested place; strings added to en/ar/zh-CN. Closes chaitanyagiri#355
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The onboarding engine step filtered to inbox-capable providers, so Copilot (and Kimi) simply vanished — which reads as "not supported at all" (issue #355), while Settings → prerequisites happily shows Copilot two screens later. The real constraint is narrower: a print-mode / bridge-less CLI can be hired as a worker but cannot run Michael, because the orchestrator must drain hive mail. The step now shows every preset engine: the god-eligible set stays selectable exactly as before (same order), and the workers-only engines render at the bottom as disabled rows — muted, radio disabled, a
WORKERS ONLYbadge, and a one-line hint saying why and that hiring them as workers still works.customstays hidden (a bring-your-own command, not a preset engine). The split lives in one tested helper (onboardingEngineChoices()), and the strings landed in all three locales (en / ar / zh-CN).Closes #355
Type of change
Evidence
Before
Onboarding step 2 on
main, scrolled to the bottom: the list ends at Cursor — Copilot and Kimi are nowhere, with no explanation:After
The same step, same window size and theme: Kimi Code and Copilot appear at the bottom as disabled
WORKERS ONLYrows with the reason ("Can't drain hive mail yet, so it can't run your clone — still available when hiring workers"); the selectable set above is unchanged:How I tested it
onboardingEngineChoicessplit: selectable === god-eligible set in the same order, workers-only ===['kimi','copilot'],customin neither), watched it fail, then implemented:node test/provider-config.test.cjs— 8/8 pass.npm run typecheck(node + web) passes;npm run test:focused— 746/746;npm run buildsucceeds.npm run dev, walked onboarding to the engine step on this branch and onmainat the same window size (screenshots above); confirmed the disabled rows can't be selected and the radio/model flow for eligible engines is untouched.--cth-paper-100,--cth-ink-300/500,--cth-font-display) — no new colors or spacing values.Discord (optional)
Discord:
Checklist
npm run typecheckpasses.npm run test:focusedpasses.npm run buildsucceeds.DESIGN.md/tokens.ts— no ad-hoc colors, spacing, or fonts.ATTRIBUTION.md. (No art added — only existing tokens and icons.)