fix(plugin): wire .mcp.json remote MCP server for plugin installs#60
Merged
Conversation
…CLAUDE.md Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@claude review |
Contributor
|
🤖 Claude security review requested by @lxcong. Running against HEAD |
|
🤖 Claude security review — HEAD: 02f4220 Scope: 4 files — ✅ No security or convention issues found. Checks performed:
Review triggered by @lxcong |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude-plugin/plugin.json+marketplace.json), but.mcp.jsonwas empty ({ "mcpServers": {} }), so installing the plugin registered no MCP server — the skill loaded with no tools to call..mcp.jsonto register atype: httpserver athttps://api.agentkey.app/v1/mcp, injecting the API key via the documented${user_config.AGENTKEY_API_KEY}interpolation (the manifest already declaresuserConfig.AGENTKEY_API_KEY).${CLAUDE_PLUGIN_OPTION_*}env vars only apply to stdio/subprocess servers, not to an http server header..mcp.jsonguidance in.claude/CLAUDE.md, and document the public marketplace install path (/plugin marketplace add chainbase-labs/agentkey) inREADME.md+docs/README_zh.md.Scope: only
.mcp.json,.claude/CLAUDE.md,README.md,docs/README_zh.md(+28/-10). Version/release files untouched; thefix:lets release-please cut 1.9.1 on merge.Test Plan
claude plugin validate .passesclaude plugin marketplace add ./+claude plugin install agentkey@agentkey --config AGENTKEY_API_KEY=…→plugin:agentkey:agentkey … ✓ Connected, confirming${user_config.*}is interpolated into the auth header and the server authenticatesbats tests/10/10 pass🤖 Generated with Claude Code