Skip to content

Fix task selection #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicoPennec merged 3 commits into from
May 13, 2026
+123 −59
Merged

Fix task selection #2012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b75d136
[qa] fix edge case of unknown task id
NicoPennec May 13, 2026
233e894
[entities] fix shift-click range selection on tasks
NicoPennec May 13, 2026
b5cb012
[qa] bump dependencies
NicoPennec May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
159 changes: 106 additions & 53 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"@fullcalendar/multimonth": "6.1.20",
"@fullcalendar/vue3": "6.1.20",
"@google/model-viewer": "4.2.0",
"@sentry/vue": "10.53.0",
"@sentry/vue": "10.53.1",
"@unhead/vue": "3.1.0",
"@vuepic/vue-datepicker": "11.0.3",
"bowser": "2.14.1",
Expand All @@ -49,7 +49,7 @@
"moment-timezone": "0.6.2",
"panzoom": "9.4.4",
"papaparse": "5.5.3",
"qrcode.vue": "3.9.0",
"qrcode.vue": "3.9.1",
"sanitize-html": "2.17.3",
"socket.io-client": "4.8.3",
"superagent": "10.3.0",
Expand All @@ -63,7 +63,7 @@
"vue-chartkick": "1.1.0",
"vue-i18n": "9.14.5",
"vue-multiselect": "3.5.0",
"vue-router": "5.0.6",
"vue-router": "5.0.7",
"vue-websocket-next": "0.2.7",
"vue3-emoji-picker": "1.1.8",
"vuedraggable": "4.1.0",
Expand Down
13 changes: 12 additions & 1 deletion src/components/cells/ValidationCell.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@

<script setup>
import { EyeIcon } from 'lucide-vue-next'
import { computed, onMounted, ref, watch } from 'vue'
import { computed, onMounted, ref, toRef, watch } from 'vue'
import { useStore } from 'vuex'

import { useFormat } from '@/composables/format'
Expand Down Expand Up @@ -222,6 +222,17 @@ const onClick = event => {
watch(() => props.taskTest, resolveTask)

onMounted(resolveTask)

// Read via $refs by entity_list.js / selection.js for shift-click range selection.
// <script setup> hides everything by default.
defineExpose({
task,
selectable: toRef(props, 'selectable'),
entity: toRef(props, 'entity'),
column: toRef(props, 'column'),
rowX: toRef(props, 'rowX'),
columnY: toRef(props, 'columnY')
})
</script>

<style lang="scss" scoped>
Expand Down
4 changes: 2 additions & 2 deletions src/components/lists/EntityTaskList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,8 @@ export default {
entityProgress() {
const doneTasks = this.entries.filter(task => {
const fullTask = this.getTask(task.id)
const taskStatus = this.taskStatusMap.get(fullTask.task_status_id)
return taskStatus.is_done
const taskStatus = this.taskStatusMap.get(fullTask?.task_status_id)
return taskStatus?.is_done
})
return `${doneTasks.length} / ${this.entries.length}`
},
Expand Down