cfe-4623: fix modules_presence update bundle for 3.28.x(master) version and newer#3119
Open
craigcomstock wants to merge 4 commits intocfengine:masterfrom
Open
cfe-4623: fix modules_presence update bundle for 3.28.x(master) version and newer#3119craigcomstock wants to merge 4 commits intocfengine:masterfrom
craigcomstock wants to merge 4 commits intocfengine:masterfrom
Conversation
craigcomstock
force-pushed
the
cfe-4623/master
branch
6 times, most recently
from
41062f2 to
b3f2373
Compare
|
Thank you for submitting a pull request! Maybe @nickanderson can review this? |
…s instead of ancient 3.23 version available in alpine Ticket: CFE-4623 Changelog: none
craigcomstock
force-pushed
the
cfe-4623/master
branch
2 times, most recently
from
f57a69c to
18fa417
Compare
craigcomstock
changed the title
Contributor
Author
|
this fixes valgrind-checks in jenkins also: |
…result on 3.27.0 and newer versions Ticket: CFE-4623 Changelog: none
craigcomstock
force-pushed
the
cfe-4623/master
branch
from
18fa417 to
07b01ae
Compare
nickanderson
approved these changes
Apr 12, 2026
Member
nickanderson
left a comment
nickanderson
left a comment
There was a problem hiding this comment.
Cool, I think we could tweak the condition further
craigcomstock
force-pushed
the
cfe-4623/master
branch
2 times, most recently
from
684d94a to
96160e1
Compare
…important versions of CFEngine Especially this was in relation to changing behavior of findfiles() around 3.24, 3.27 and 3.28 versions. Ticket: CFE-4623 Changelog: none
craigcomstock
force-pushed
the
cfe-4623/master
branch
from
e320219 to
87a05fa
Compare
The findfiles() trailing slash behavior is fixed in master, so we should not apply the workaround to those versions.
nickanderson
approved these changes
Apr 13, 2026
Member
nickanderson
left a comment
nickanderson
left a comment
There was a problem hiding this comment.
I pushed a change to the version detection to your pr. should be good and ready for squash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CFE-4623
Changelog: none
with cfengine/core#6069