Fix zero-length group matches#40
Open
Avlaak wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix zero-length group matches
Summary
When a capturing group matches but captures zero characters (e.g.
([0-9]*)ona non-digit input), the corresponding
slre_capentry was left uninitialized.This change explicitly sets
ptr = NULLandlen = 0for such captures.Root cause
In
bar(), the capture assignment only ran whenn > 0:When a group like
([0-9]*)legitimately matched zero characters (n == 0),the
capsslot was never written to. The caller received stale oruninitialized data, making it impossible to distinguish "group participated
but captured nothing" from "group was never evaluated".
Fix
Added an
else ifbranch forn == 0:This gives callers a clear contract:
ncaps[i].ptrcaps[i].lenNULLTests
Added regression tests for zero-length captures:
([0-9]*)on"abc"— match returns 0,ptr == NULL,len == 0"([0-9]*)"on""— match returns 2,ptr == NULL,len == 0"([0-9]*)" "([0-9]*)"on"" "1"— first capNULL/0, second cap"1"/1([0-9]*) ([0-9]*)on"1 abc"— first cap"1"/1, second capNULL/0