Skip to content

feat(datagrid): move grid filters into a shared filter bar - #874

Merged
lcottercertinia merged 6 commits into
certinia:mainfrom
lukecotter:feat-grid-filter-redesign
Jul 27, 2026
Merged

feat(datagrid): move grid filters into a shared filter bar#874
lcottercertinia merged 6 commits into
certinia:mainfrom
lukecotter:feat-grid-filter-redesign

Conversation

@lukecotter

@lukecotter lukecotter commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

📝 PR Overview

Moves the per-column header filters out of the column headers into one filter bar above each grid (Call Tree, Database), so filtering is discoverable in a single place and scales down to narrow windows. Also tidies the shared grid styling and fixes the Database usage bars.

🛠️ Changes made

  • New datagrid-facet-filter (multi-select, with a selected-count) and datagrid-range-filter (min–max) controls, wired through datagrid-filter-bar; removes the per-column list / MinMax header editors (tabulator/editors/MinMax.* deleted).
  • OverflowList: when the bar is narrow the filters collapse behind a Filter button that opens them in a panel with slot-aware inline controls; popovers flip to stay on-screen and re-measure when a filter's value changes.
  • ContextMenu (Columns / field menu): capped to the viewport with scroll, repositions on window resize, and adds checkbox↔label spacing.
  • Consolidated the Database (DML/SOQL/SOSL) tables onto the shared Call Tree column/sort styling and filter-control / popover design tokens; crisper grid header separator.
  • Fixed the Database usage bars (Row Count, Time Taken) to fill against the grid's own column total instead of a governor limit, so they show for small values and on group rows.

🧩 Type of change (check all applicable)

  • 🐛 Bug fix - something not working as expected
  • ✨ New feature – adds new functionality
  • ♻️ Refactor - internal changes with no user impact
  • ⚡ Performance Improvement
  • 📝 Documentation - README or documentation site changes
  • 🔧 Chore - dev tooling, CI, config
  • 💥 Breaking change

📷 Screenshots / gifs / video [optional]

image image image

🔗 Related Issues

closes #873
related #604
related #112
related #538
related #299

✅ Tests added?

  • 👍 yes

📚 Docs updated?

  • 🔖 README.md
  • 🔖 CHANGELOG.md
  • 📖 help site

Anything else we need to know? [optional]

Known limitation (deferred): on a very narrow window in Bottom-Up view, the divider between the Columns selector and the filters can be overlapped by the right-hand cluster. Fixing it cleanly needs the toolbar to wrap, which conflicts with the current filter-collapse mechanism — tracked for a follow-up.

Facet, range and search filters move out of column headers into a responsive
filter bar shared by Call Tree, Analysis and Database.

- add datagrid-facet-filter / datagrid-range-filter native-popover controls and
  wire them plus a global search box through datagrid-filter-bar, replacing the
  per-column list/MinMax header editors (editors/MinMax removed)
- OverflowList: collapse overflowing filters into a filter-icon popover panel
  with slot-aware inline controls, re-measure on child resize, and on-screen flip
- consolidate Database (DML/SOQL/SOSL) tables onto the Call Tree column/sort
  styling and shared filter-control/popover tokens in global.styles
- fix usage bars (Row Count, Time Taken): fill against the grid's own column
  total, not a governor limit, so they show for small values and on group rows
- cap the menu to the viewport (max-height: calc(100vh - 24px), border-box) and
  scroll the overflow so long field lists stay fully reachable on short screens
- reposition on window resize, and reset-to-anchor before clamping in
  adjustPosition(), so an open menu can't drift off-screen when the viewport shrinks
- add an 8px gap between each row's checkbox and its label
…ADME

- changelog: reword the filter bar and full-table search entries in plain
  language and cite the relevant issues (certinia#604, certinia#112, certinia#538, certinia#299, certinia#488, certinia#539)
- README: correct the Call Tree / Analysis / Database filter bullets to match
  the new filter bar (Analysis no longer has a type filter; add a Database line)
@lcottercertinia
lcottercertinia merged commit 3748815 into certinia:main Jul 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ feat: move grid filters into a shared filter bar

2 participants