Skip to content

Force dependencyDashboardApproval for renovate/renovate - #15

Merged
cert-manager-prow[bot] merged 1 commit into
mainfrom
renovate/reconfigure
Sep 13, 2025
Merged

Force dependencyDashboardApproval for renovate/renovate#15
cert-manager-prow[bot] merged 1 commit into
mainfrom
renovate/reconfigure

Conversation

@erikgb

@erikgb erikgb commented Sep 13, 2025

Copy link
Copy Markdown
Member

With the current configuration, #13 should require a dependency dashboard approval. But somehow this is not working. Same issue in cert-manager/makefile-modules#429.

I'm trying to make the package rule even more precise to see if it works.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the Renovate configuration to ensure that updates to the renovate/renovate package require dependency dashboard approval. The change moves the package-specific rule to be more tightly scoped within the GitHub Actions manager configuration.

  • Relocates the renovate/renovate dependency dashboard approval rule to be positioned within GitHub Actions-specific rules
  • Adds an exclusion rule for renovate/renovate to the general GitHub Actions configuration
  • Creates a dedicated rule that explicitly requires dashboard approval for renovate/renovate updates

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread default.json5 Outdated
@erikgb
erikgb force-pushed the renovate/reconfigure branch from 6ef6543 to 4913a7e Compare September 13, 2025 09:41
@erikgb
erikgb requested a review from Copilot September 13, 2025 09:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread default.json5 Outdated
@cert-manager cert-manager deleted a comment from octo-sts Bot Sep 13, 2025
@erikgb
erikgb force-pushed the renovate/reconfigure branch from 4913a7e to 4b20915 Compare September 13, 2025 09:46
@erikgb
erikgb requested a review from Copilot September 13, 2025 09:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@octo-sts

octo-sts Bot commented Sep 13, 2025

Copy link
Copy Markdown
Contributor

Reconfigure PR Results

This is an reconfigure PR comment to help you understand and re-configure your renovate bot settings. If this Reconfigure PR were to be merged, we'd expect to see the following outcome:


Detected Package Files

  • .github/workflows/run-renovate.yaml (github-actions)
  • .github/workflows/validate-renovate-config.yaml (github-actions)
  • .github/renovate.json5 (renovate-config-presets)

Configuration Summary

Based on the default config's presets, Renovate will:

  • Enable Renovate Dependency Dashboard creation.
  • Use semantic commit type fix for dependencies and chore for all others if semantic commits are in use.
  • Ignore node_modules, bower_components, vendor and various test/tests (except for nuget) directories.
  • Group known monorepo packages together.
  • Use curated list of recommended non-monorepo package groupings.
  • Show only the Age and Confidence Merge Confidence badges for pull requests.
  • Apply crowd-sourced package replacement rules.
  • Apply crowd-sourced workarounds for known problems with packages.
  • Pin Docker digests.
  • Pin github-action digests.
  • Enable Renovate configuration migration PRs when needed.
  • Pin dependency versions for development dependencies.
  • Update _VERSION environment variables in GitHub Action files.
  • Append Signed-off-by: to signoff Git commits.
  • Use semantic prefixes for commit messages and PR titles.
  • Disable vulnerability alerts completely.
  • Remove hourly and concurrent rate limits.
  • Enable Renovate Dependency Dashboard creation.
  • Use semantic commit type fix for dependencies and chore for all others if semantic commits are in use.
  • Ignore node_modules, bower_components, vendor and various test/tests (except for nuget) directories.
  • Group known monorepo packages together.
  • Use curated list of recommended non-monorepo package groupings.
  • Show only the Age and Confidence Merge Confidence badges for pull requests.
  • Apply crowd-sourced package replacement rules.
  • Apply crowd-sourced workarounds for known problems with packages.
  • Pin Docker digests.
  • Pin github-action digests.
  • Enable Renovate configuration migration PRs when needed.
  • Pin dependency versions for development dependencies.
  • Update _VERSION environment variables in GitHub Action files.
  • Append Signed-off-by: to signoff Git commits.
  • Use semantic prefixes for commit messages and PR titles.
  • Disable vulnerability alerts completely.
  • Remove hourly and concurrent rate limits.

What to Expect

With your current configuration, Renovate will create 1 Pull Request:

chore(deps): update renovate/renovate docker tag to v41.113.0
  • Schedule: ["at any time"]
  • Branch name: renovate/misc-github-actions
  • Merge into: main
  • Upgrade renovate/renovate to sha256:46e484b5bd6c8b322d0925ec2b7614e11b17a700870ce620293a26a3abc067ad

@erikgb

erikgb commented Sep 13, 2025

Copy link
Copy Markdown
Member Author

/cc @hjoshi123 @ThatsMrTalbot

@hjoshi123

Copy link
Copy Markdown

/lgtm

Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@erikgb

erikgb commented Sep 13, 2025

Copy link
Copy Markdown
Member Author

/approve

@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hjoshi123

Copy link
Copy Markdown

The PR looks good to me now. The comments helps in readability.
/lgtm

@cert-manager-prow
cert-manager-prow Bot merged commit cb9abba into main Sep 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants