Force dependencyDashboardApproval for renovate/renovate - #15
Conversation
a91fe92 to
79657b8
Compare
79657b8 to
6790c5a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refines the Renovate configuration to ensure that updates to the renovate/renovate package require dependency dashboard approval. The change moves the package-specific rule to be more tightly scoped within the GitHub Actions manager configuration.
- Relocates the
renovate/renovatedependency dashboard approval rule to be positioned within GitHub Actions-specific rules - Adds an exclusion rule for
renovate/renovateto the general GitHub Actions configuration - Creates a dedicated rule that explicitly requires dashboard approval for
renovate/renovateupdates
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
6ef6543 to
4913a7e
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
4913a7e to
4b20915
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Reconfigure PR ResultsThis is an reconfigure PR comment to help you understand and re-configure your renovate bot settings. If this Reconfigure PR were to be merged, we'd expect to see the following outcome: Detected Package Files
Configuration SummaryBased on the default config's presets, Renovate will:
What to ExpectWith your current configuration, Renovate will create 1 Pull Request: chore(deps): update renovate/renovate docker tag to v41.113.0
|
|
/lgtm |
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
4b20915 to
c2d130c
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The PR looks good to me now. The comments helps in readability. |
With the current configuration, #13 should require a dependency dashboard approval. But somehow this is not working. Same issue in cert-manager/makefile-modules#429.
I'm trying to make the package rule even more precise to see if it works.