Skip to content

Correct GHA version markers - #428

Merged
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
erikgb:fix-action-version-merkers
Sep 11, 2025
Merged

Correct GHA version markers#428
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
erikgb:fix-action-version-merkers

Conversation

@erikgb

@erikgb erikgb commented Sep 11, 2025

Copy link
Copy Markdown
Member

I prefer to see the human-readable exact version - even if we use digests.

Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@cert-manager-prow cert-manager-prow Bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Sep 11, 2025
@erikgb
erikgb requested a review from Copilot September 11, 2025 16:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates GitHub Actions version comments to include full semantic version numbers instead of abbreviated versions, providing better clarity about exact versions being used while maintaining digest-based pinning for security.

  • Replaced abbreviated version comment "main" with specific version "v1.0.1" for octo-sts/action
  • Changed abbreviated version comment "v6" to full version "v6.0.0" for actions/setup-go

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
modules/repository-base/base/.github/workflows/renovate.yaml Updated octo-sts/action version comment from "main" to "v1.0.1"
.github/workflows/e2e-test.yaml Updated actions/setup-go version comment from "v6" to "v6.0.0"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cert-manager-prow cert-manager-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2025
@hjoshi123

Copy link
Copy Markdown
Contributor

/approve

@hjoshi123

Copy link
Copy Markdown
Contributor

/lgtm

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2025
@erikgb

erikgb commented Sep 11, 2025

Copy link
Copy Markdown
Member Author

/approve

@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb, hjoshi123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2025
@cert-manager-prow
cert-manager-prow Bot merged commit a6ac1de into cert-manager:main Sep 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants