fix(ci): changing glob patterns - #387
Merged
cert-manager-prow[bot] merged 1 commit intoSep 1, 2025
Merged
Conversation
cert-manager-prow
Bot
added
dco-signoff: yes
hjoshi123
force-pushed
the
fix/glob-patterns
branch
from
September 1, 2025 19:40
fbece86 to
16c66cb
Compare
cert-manager-prow
Bot
added
size/XS
hjoshi123
force-pushed
the
fix/glob-patterns
branch
from
September 1, 2025 20:04
16c66cb to
67b9d42
Compare
cert-manager-prow
Bot
added
size/S
erikgb
reviewed
Sep 1, 2025
hjoshi123
force-pushed
the
fix/glob-patterns
branch
from
September 1, 2025 20:20
67b9d42 to
cbd3205
Compare
Signed-off-by: hjoshi123 <mail@hjoshi.me>
hjoshi123
force-pushed
the
fix/glob-patterns
branch
from
September 1, 2025 20:28
cbd3205 to
ad36ccc
Compare
erikgb
reviewed
Sep 1, 2025
erikgb
left a comment
erikgb
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for fixing my Glob-mess, @hjoshi123! 🚀
/lgtm
/approve
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We saw a bug https://github.com/cert-manager/istio-csr/pulls where the testing libs were not getting matched properly due to the glob patterns.