Skip to content

fix: remove hardcoded 500 MB download size limit - #368

Merged
cebarks merged 1 commit into
mainfrom
worktree-fix+remove-download-size-limit
Jul 30, 2026
Merged

fix: remove hardcoded 500 MB download size limit#368
cebarks merged 1 commit into
mainfrom
worktree-fix+remove-download-size-limit

Conversation

@cebarks

@cebarks cebarks commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • Removes the hardcoded MAX_DOWNLOAD_SIZE (500 MB) cap from ForgeClient::download_file
  • Both the content-length pre-check and the streaming byte-count guard are removed
  • Downloads are user-initiated and disk space is the real constraint — the arbitrary limit could block legitimate large mods

Closes #324

Test plan

  • cargo check passes
  • Install a mod larger than 500 MB (if available) to confirm no rejection

Implemented with the help of Claude Code

The arbitrary MAX_DOWNLOAD_SIZE cap could block legitimate large mods.
Downloads are user-initiated and disk space is the real constraint.

Closes #324

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@cebarks
cebarks enabled auto-merge (squash) July 30, 2026 02:14
@cebarks
cebarks merged commit 5abb84e into main Jul 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove hardcoded download size limit / add configuration option for download size limit

1 participant