fix(notifications): skip due and reminder notifs for paused chores#195
Merged
Conversation
…used chores When a user's chores are paused (chores_paused = true), they still received "due soon" and "reminder" push notifications for their assigned chores. Only overdue notifications were correctly suppressed. The `_process_due_window()` and `_process_due_reminder()` methods in the chore manager emitted notification signals without checking the user's pause state, while `_process_overdue()` already had this guard. This aligns all three time-based notification pipelines to skip paused users, so pausing chores now silences all chore notifications instead of only overdue ones.
ccpk1
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user's chores are paused (chores_paused = true), they still received "due soon" and "reminder" push notifications for their assigned chores. Only overdue notifications were correctly suppressed.
The
_process_due_window()and_process_due_reminder()methods in the chore manager emitted notification signals without checking the user's pause state, while_process_overdue()already had this guard.This aligns all three time-based notification pipelines to skip paused users, so pausing chores now silences all chore notifications instead of only overdue ones.
Closes #194