Fix venv setup instructions to make sure we use uv lockfile#162
Merged
Conversation
8 tasks
wagnerlmichael
approved these changes
May 14, 2026
wagnerlmichael
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix and the write-up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #158 we tweaked the
generate-homevalworkflow to ensure it installs the exact Python package versions listed inscripts/generate_homeval/uv.lock, but we didn't touch the setup instructions in the README, so those instructions continue to list installation commands that will ignore the lockfile. This PR tweaks those instructions to make sure the commands install the package versions listed in the uv lockfile.I tested this change by removing my virtualenv, following the new instructions to recreate it, and confirming that A) the package versions match the lockfile and B) a
generate_homeval.pycall continues to work: