Skip to content

Fix venv setup instructions to make sure we use uv lockfile#162

Merged
jeancochrane merged 1 commit into
mainfrom
jeancochrane/fix-venv-setup-instructions
May 14, 2026
Merged

Fix venv setup instructions to make sure we use uv lockfile#162
jeancochrane merged 1 commit into
mainfrom
jeancochrane/fix-venv-setup-instructions

Conversation

@jeancochrane

@jeancochrane jeancochrane commented May 14, 2026

Copy link
Copy Markdown
Member

In #158 we tweaked the generate-homeval workflow to ensure it installs the exact Python package versions listed in scripts/generate_homeval/uv.lock, but we didn't touch the setup instructions in the README, so those instructions continue to list installation commands that will ignore the lockfile. This PR tweaks those instructions to make sure the commands install the package versions listed in the uv lockfile.

I tested this change by removing my virtualenv, following the new instructions to recreate it, and confirming that A) the package versions match the lockfile and B) a generate_homeval.py call continues to work:

cd scripts/generate_homeval
rm -rf .venv
uv sync --frozen
source .venv/bin/activate
cd ../..
python3 scripts/generate_homeval/generate_homeval.py --run-id 2025-06-14-flamboyant-rob --pin 01011000040000 10112040080000

@wagnerlmichael wagnerlmichael left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the write-up!

@jeancochrane jeancochrane merged commit e1b1764 into main May 14, 2026
1 check passed
@jeancochrane jeancochrane deleted the jeancochrane/fix-venv-setup-instructions branch May 14, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants